Add int64in/out record support#161
Merged
AlexanderWells-diamond merged 5 commits intomasterfrom Jun 7, 2024
Merged
Conversation
Unit Test Results 8 files ± 0 8 suites ±0 10m 12s ⏱️ +18s Results for commit d38df9b. ± Comparison against base commit 4bbc933. This pull request removes 14 and adds 27 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
|
It is necessary as ChannelAccess does not support int64 natively, instead transferring it using a double. This means the value returned from caget is actually a float, which is inconvenient. Fortunately p4p (using PVAccess) does support int64! I deleted some test cases as they were really testing the behaviour of caget/caput, and not pythonSoftIoc itself.
AlexanderWells-diamond
force-pushed
the
add_int64_records
branch
from
e5fa971 to
d38df9b
Compare
Collaborator
Author
|
Requested changes have been made. Tests are failing due to #158 still waiting for upstream dependencies for Python 3.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the int64in and int64out record types.
There's two TODOs and some test failures that needs discussion:
DBR_*types we use come fromepicscorelibs, however its latest version does not define the (new)DBR_INT64andDBR_UINT64types. Is it worth trying to get a PR through that module that adds these codes before merging this?cagetnot being able to transport an int64, instead transporting it as a float. Should I special-case these tests to accept this, or is there a better mechanism to force what we want? I see thatcagetdoes NOT claim to supportdatatype=DBR_INT64.Various reference materials:
Changelog for introduction of the records: https://github.com/epics-base/epics-base/blob/7.0/documentation/RELEASE_NOTES.md#ioc-database-support-for-64-bit-integers
EPICS header file that defines both DBR_ and DBF_ codes: https://github.com/epics-base/epics-base/blob/7.0/modules/database/src/ioc/dbStatic/dbFldTypes.h
Closes #160 Closes #118